undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge branch 'jk/clean-d-pathspec' into maint

Browse Source 
"git clean -d pathspec" did not use the given pathspec correctly
and ended up cleaning too much.

* jk/clean-d-pathspec:
  clean: simplify dir/not-dir logic
  clean: respect pathspecs with "-d"
This commit is contained in:
Junio C Hamano 2014-03-18 14:04:59 -07:00
commit 9526473f11
2 changed files with 25 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
builtin/clean.c
View File

@ -946,17 +946,15 @@ int cmd_clean(int argc, const char **argv, const char *prefix)
if (pathspec.nr) if (pathspec.nr)
matches = dir_path_match(ent, &pathspec, 0, NULL); matches = dir_path_match(ent, &pathspec, 0, NULL);
if (S_ISDIR(st.st_mode)) { if (pathspec.nr && !matches)
if (remove_directories || (matches == MATCHED_EXACTLY)) { continue;
rel = relative_path(ent->name, prefix, &buf);
string_list_append(&del_list, rel); if (S_ISDIR(st.st_mode) && !remove_directories &&
} matches != MATCHED_EXACTLY)
} else { continue;
if (pathspec.nr && !matches)
continue; rel = relative_path(ent->name, prefix, &buf);
rel = relative_path(ent->name, prefix, &buf); string_list_append(&del_list, rel);
string_list_append(&del_list, rel);
}
} }
if (interactive && del_list.nr > 0) if (interactive && del_list.nr > 0)

16
t/t7300-clean.sh
View File

@ -511,4 +511,20 @@ test_expect_success SANITY 'git clean -d with an unreadable empty directory' '
! test -d foo ! test -d foo
' '
test_expect_success 'git clean -d respects pathspecs (dir is prefix of pathspec)' '
mkdir -p foo &&
mkdir -p foobar &&
git clean -df foobar &&
test_path_is_dir foo &&
test_path_is_missing foobar
'
test_expect_success 'git clean -d respects pathspecs (pathspec is prefix of dir)' '
mkdir -p foo &&
mkdir -p foobar &&
git clean -df foo &&
test_path_is_missing foo &&
test_path_is_dir foobar
'
test_done test_done