undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

t/README: hint about using $(pwd) rather than $PWD in tests

Browse Source 
This adds just a "do it this way" instruction without a lot of explanation,
because the details are too complex to be explained at this point.

Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Johannes Sixt 2011-01-11 08:44:30 +01:00 committed by Junio C Hamano
parent e6ec2b6a23
commit 95b104c830
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
t/README
View File

@ -283,6 +283,12 @@ Do:
Tests that are likely to smoke out future regressions are better Tests that are likely to smoke out future regressions are better
than tests that just inflate the coverage metrics. than tests that just inflate the coverage metrics.
- When a test checks for an absolute path that a git command generated,
construct the expected value using $(pwd) rather than $PWD,
$TEST_DIRECTORY, or $TRASH_DIRECTORY. It makes a difference on
Windows, where the shell (MSYS bash) mangles absolute path names.
For details, see the commit message of 4114156ae9.
Don't: Don't:
- exit() within a <script> part. - exit() within a <script> part.