undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge branch 'ml/worktree'

Browse Source 
* ml/worktree:
  make git barf when an alias changes environment variables
This commit is contained in:
Junio C Hamano 2007-07-01 13:11:01 -07:00
commit 96c48153c9
1 changed files with 18 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
git.c
View File

@ -28,7 +28,7 @@ static void prepend_to_path(const char *dir, int len)
free(path); free(path);
} }
static int handle_options(const char*** argv, int* argc) static int handle_options(const char*** argv, int* argc, int* envchanged)
{ {
int handled = 0; int handled = 0;
@ -64,24 +64,34 @@ static int handle_options(const char*** argv, int* argc)
usage(git_usage_string); usage(git_usage_string);
} }
setenv(GIT_DIR_ENVIRONMENT, (*argv)[1], 1); setenv(GIT_DIR_ENVIRONMENT, (*argv)[1], 1);
if (envchanged)
*envchanged = 1;
(*argv)++; (*argv)++;
(*argc)--; (*argc)--;
handled++; handled++;
} else if (!prefixcmp(cmd, "--git-dir=")) { } else if (!prefixcmp(cmd, "--git-dir=")) {
setenv(GIT_DIR_ENVIRONMENT, cmd + 10, 1); setenv(GIT_DIR_ENVIRONMENT, cmd + 10, 1);
if (envchanged)
*envchanged = 1;
} else if (!strcmp(cmd, "--work-tree")) { } else if (!strcmp(cmd, "--work-tree")) {
if (*argc < 2) { if (*argc < 2) {
fprintf(stderr, "No directory given for --work-tree.\n" ); fprintf(stderr, "No directory given for --work-tree.\n" );
usage(git_usage_string); usage(git_usage_string);
} }
setenv(GIT_WORK_TREE_ENVIRONMENT, (*argv)[1], 1); setenv(GIT_WORK_TREE_ENVIRONMENT, (*argv)[1], 1);
if (envchanged)
*envchanged = 1;
(*argv)++; (*argv)++;
(*argc)--; (*argc)--;
} else if (!prefixcmp(cmd, "--work-tree=")) { } else if (!prefixcmp(cmd, "--work-tree=")) {
setenv(GIT_WORK_TREE_ENVIRONMENT, cmd + 12, 1); setenv(GIT_WORK_TREE_ENVIRONMENT, cmd + 12, 1);
if (envchanged)
*envchanged = 1;
} else if (!strcmp(cmd, "--bare")) { } else if (!strcmp(cmd, "--bare")) {
static char git_dir[PATH_MAX+1]; static char git_dir[PATH_MAX+1];
setenv(GIT_DIR_ENVIRONMENT, getcwd(git_dir, sizeof(git_dir)), 1); setenv(GIT_DIR_ENVIRONMENT, getcwd(git_dir, sizeof(git_dir)), 1);
if (envchanged)
*envchanged = 1;
} else { } else {
fprintf(stderr, "Unknown option: %s\n", cmd); fprintf(stderr, "Unknown option: %s\n", cmd);
usage(git_usage_string); usage(git_usage_string);
@ -160,7 +170,7 @@ static int split_cmdline(char *cmdline, const char ***argv)
static int handle_alias(int *argcp, const char ***argv) static int handle_alias(int *argcp, const char ***argv)
{ {
int nongit = 0, ret = 0, saved_errno = errno; int nongit = 0, envchanged = 0, ret = 0, saved_errno = errno;
const char *subdir; const char *subdir;
int count, option_count; int count, option_count;
const char** new_argv; const char** new_argv;
@ -181,7 +191,11 @@ static int handle_alias(int *argcp, const char ***argv)
alias_string + 1, alias_command); alias_string + 1, alias_command);
} }
count = split_cmdline(alias_string, &new_argv); count = split_cmdline(alias_string, &new_argv);
option_count = handle_options(&new_argv, &count); option_count = handle_options(&new_argv, &count, &envchanged);
if (envchanged)
die("alias '%s' changes environment variables\n"
"You can use '!git' in the alias to do this.",
alias_command);
memmove(new_argv - option_count, new_argv, memmove(new_argv - option_count, new_argv,
count * sizeof(char *)); count * sizeof(char *));
new_argv -= option_count; new_argv -= option_count;
@ -402,7 +416,7 @@ int main(int argc, const char **argv)
/* Look for flags.. */ /* Look for flags.. */
argv++; argv++;
argc--; argc--;
handle_options(&argv, &argc); handle_options(&argv, &argc, NULL);
if (argc > 0) { if (argc > 0) {
if (!prefixcmp(argv[0], "--")) if (!prefixcmp(argv[0], "--"))
argv[0] += 2; argv[0] += 2;