undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge branch 'jk/format-person-part-buffer-limit'

Browse Source 
Avoid buffer overflow in format_person_part() function
This commit is contained in:
Junio C Hamano 2012-05-25 12:06:16 -07:00
commit 9972c8ea49
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
pretty.c
View File

@ -550,8 +550,10 @@ static size_t format_person_part(struct strbuf *sb, char part,
mail_end = s.mail_end;
if (part == 'N' || part == 'E') { /* mailmap lookup */
strlcpy(person_name, name_start, name_end - name_start + 1);
strlcpy(person_mail, mail_start, mail_end - mail_start + 1);
snprintf(person_name, sizeof(person_name), "%.*s",
(int)(name_end - name_start), name_start);
snprintf(person_mail, sizeof(person_mail), "%.*s",
(int)(mail_end - mail_start), mail_start);
mailmap_name(person_mail, sizeof(person_mail), person_name, sizeof(person_name));
name_start = person_name;
name_end = name_start + strlen(person_name);