undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cmd_fetch_pack(): declare dest to be const

Browse Source 
There is no need for it to be non-const, and this avoids the need
for casting away the constness of an argv element.

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Michael Haggerty 2012-05-21 09:59:56 +02:00 committed by Junio C Hamano
parent 078b895fef
commit 9d19c6ea52
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
builtin/fetch-pack.c
View File

@ -900,7 +900,8 @@ int cmd_fetch_pack(int argc, const char **argv, const char *prefix)
{ {
int i, ret, nr_heads; int i, ret, nr_heads;
struct ref *ref = NULL; struct ref *ref = NULL;
char *dest = NULL, **heads; const char *dest = NULL;
char **heads;
int fd[2]; int fd[2];
char *pack_lockfile = NULL; char *pack_lockfile = NULL;
char **pack_lockfile_ptr = NULL; char **pack_lockfile_ptr = NULL;
@ -970,7 +971,7 @@ int cmd_fetch_pack(int argc, const char **argv, const char *prefix)
} }
usage(fetch_pack_usage); usage(fetch_pack_usage);
} }
dest = (char *)arg; dest = arg;
heads = (char **)(argv + i + 1); heads = (char **)(argv + i + 1);
nr_heads = argc - i - 1; nr_heads = argc - i - 1;
break; break;
@ -1017,7 +1018,7 @@ int cmd_fetch_pack(int argc, const char **argv, const char *prefix)
fd[0] = 0; fd[0] = 0;
fd[1] = 1; fd[1] = 1;
} else { } else {
conn = git_connect(fd, (char *)dest, args.uploadpack, conn = git_connect(fd, dest, args.uploadpack,
args.verbose ? CONNECT_VERBOSE : 0); args.verbose ? CONNECT_VERBOSE : 0);
} }