undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

git-send-email: Fix authenticating on some servers when using TLS.

Browse Source 
Send HELO again after a successful STARTTLS command to refresh the list of
extensions. These may be different to what is returned over a clear
connection (for example the AUTH command may be accepted over a secure
connection, but not over a clear connection).

Furthermore, this behaviour is recommended by RFC 2487
(http://www.ietf.org/rfc/rfc2487.txt).

Signed-off-by: Robert Shearman <robertshearman@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Robert Shearman 2008-07-09 22:39:40 +01:00 committed by Junio C Hamano
parent 607bb3ff88
commit 9d1ccf5e64
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
git-send-email.perl
View File

@ -773,6 +773,9 @@ X-Mailer: git-send-email $gitversion
$smtp = Net::SMTP::SSL->start_SSL($smtp) $smtp = Net::SMTP::SSL->start_SSL($smtp)
or die "STARTTLS failed! ".$smtp->message; or die "STARTTLS failed! ".$smtp->message;
$smtp_encryption = ''; $smtp_encryption = '';
# Send EHLO again to receive fresh
# supported commands
$smtp->hello();
} else { } else {
die "Server does not support STARTTLS! ".$smtp->message; die "Server does not support STARTTLS! ".$smtp->message;
} }