undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

t3301-notes.sh: check that default operation mode doesn't take arguments

Browse Source 
'git notes' without a subcommand defaults to listing all notes and
doesn't accept any arguments.

We are about to teach parse-options to handle subcommands, and update
'git notes' to make use of that new feature.  So let's add a test to
make sure that the upcoming changes don't inadvertenly change the
behavior in this corner case.

Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
SZEDER Gábor 2022-08-19 18:03:53 +02:00 committed by Junio C Hamano
parent 66fa6e8ed8
commit 9e4658d5c6
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
t/t3301-notes.sh
View File

@ -505,6 +505,11 @@ test_expect_success 'list notes with "git notes"' '
test_cmp expect actual test_cmp expect actual
' '
test_expect_success '"git notes" without subcommand does not take arguments' '
test_expect_code 129 git notes HEAD^^ 2>err &&
grep "^error: unknown subcommand" err
'
test_expect_success 'list specific note with "git notes list <object>"' ' test_expect_success 'list specific note with "git notes list <object>"' '
git rev-parse refs/notes/commits:$commit_3 >expect && git rev-parse refs/notes/commits:$commit_3 >expect &&
git notes list HEAD^^ >actual && git notes list HEAD^^ >actual &&