undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

git-web--browse.sh: use the $( ... ) construct for command substitution

Browse Source 
The Git CodingGuidelines prefer the $(...) construct for command
substitution instead of using the backquotes `...`.

The backquoted form is the traditional method for command
substitution, and is supported by POSIX.  However, all but the
simplest uses become complicated quickly.  In particular, embedded
command substitutions and/or the use of double quotes require
careful escaping with the backslash character.

The patch was generated by:

for _f in $(find . -name "*.sh")
do
   sed -i 's@`\(.*\)`@$(\1)@g' ${_f}
done

and then carefully proof-read.

Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Elia Pinto 2014-04-23 06:44:02 -07:00 committed by Junio C Hamano
parent d0ea45bfc7
commit 9e5878fbed
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
git-web--browse.sh
View File

@ -59,7 +59,7 @@ do
-b|--browser*|-t|--tool*) -b|--browser*|-t|--tool*)
case "$#,$1" in case "$#,$1" in
*,*=*) *,*=*)
browser=`expr "z$1" : 'z-[^=]*=\(.*\)'` browser=$(expr "z$1" : 'z-[^=]*=\(.*\)')
;; ;;
1,*) 1,*)
usage ;; usage ;;
@ -71,7 +71,7 @@ do
-c|--config*) -c|--config*)
case "$#,$1" in case "$#,$1" in
*,*=*) *,*=*)
conf=`expr "z$1" : 'z-[^=]*=\(.*\)'` conf=$(expr "z$1" : 'z-[^=]*=\(.*\)')
;; ;;
1,*) 1,*)
usage ;; usage ;;
@ -100,7 +100,7 @@ then
for opt in "$conf" "web.browser" for opt in "$conf" "web.browser"
do do
test -z "$opt" && continue test -z "$opt" && continue
browser="`git config $opt`" browser="$(git config $opt)"
test -z "$browser" || break test -z "$browser" || break
done done
if test -n "$browser" && ! valid_tool "$browser"; then if test -n "$browser" && ! valid_tool "$browser"; then