undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

git-svn: allow "0" in SVN path components

Browse Source 
Blindly checking a path component for falsiness is unwise, as
"0" is false to Perl, but a valid pathname component for SVN
(or any filesystem).

Found via random code reading.

Signed-off-by: Eric Wong <e@80x24.org>
This commit is contained in:
Eric Wong 2016-11-30 00:45:41 +00:00 committed by Junio C Hamano
parent a274e0a036
commit a0f5a0c828
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
perl/Git/SVN/Ra.pm
View File

@ -606,7 +606,7 @@ sub minimize_url {
my $latest = $ra->get_latest_revnum;
$ra->get_log("", $latest, 0, 1, 0, 1, sub {});
};
} while ($@ && ($c = shift @components));
} while ($@ && defined($c = shift @components));
return canonicalize_url($url);
}