undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cvsimport: standarize open() calls to external git tools

Browse Source 
Standardize calls to open() where external git tools are used as
part of a pipeline.  Instead of open(X, "git foo ... |)", use
open(X, "-|", qw(git foo ...)).  All calls are made without the
use of an 'sh -c' process to split the arguments.

Signed-off-by: Ben Walton <bwalton@artsci.utoronto.ca>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Ben Walton 2010-01-19 14:03:09 -05:00 committed by Junio C Hamano
parent 640d9d0873
commit a12477dbe1
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
git-cvsimport.perl
View File

@ -617,7 +617,7 @@ unless (-d $git_dir) {
$last_branch = $opt_o;
$orig_branch = "";
} else {
open(F, "git symbolic-ref HEAD |") or
open(F, "-|", qw(git symbolic-ref HEAD)) or
die "Cannot run git symbolic-ref: $!\n";
chomp ($last_branch = <F>);
$last_branch = basename($last_branch);
@ -631,8 +631,8 @@ unless (-d $git_dir) {
# Get the last import timestamps
my $fmt = '($ref, $author) = (%(refname), %(author));';
open(H, "git for-each-ref --perl --format='$fmt' $remote |") or
die "Cannot run git for-each-ref: $!\n";
my @cmd = ('git', 'for-each-ref', '--perl', "--format=$fmt", $remote);
open(H, "-|", @cmd) or die "Cannot run git for-each-ref: $!\n";
while (defined(my $entry = <H>)) {
my ($ref, $author);
eval($entry) || die "cannot eval refs list: $@";
@ -730,7 +730,7 @@ sub update_index (\@\@) {
}
sub write_tree () {
open(my $fh, '-|', "git write-tree")
open(my $fh, '-|', qw(git write-tree))
or die "unable to open git write-tree: $!";
chomp(my $tree = <$fh>);
is_sha1($tree)