undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

t5523: use test_i18ngrep for negation

Browse Source 
Replace the first form with the second one:

	! grep expected actual
	test_i18ngrep ! expected actual

The latter syntax is supported by test_i18ngrep defined in
t/test-lib.sh.

Although the test already passes whether GETTEXT_POSION is enabled, use
the i18n grep variant for the sake of consistency and also to make
obvious that those strings are subject to i18n.

Signed-off-by: Vasco Almeida <vascomalmeida@sapo.pt>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Vasco Almeida 2016-06-17 20:21:11 +00:00 committed by Junio C Hamano
parent de5ea4c6f8
commit a1347dc00c
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
t/t5523-push-upstream.sh
View File

@ -83,7 +83,7 @@ test_expect_success 'progress messages do not go to non-tty' '
# skip progress messages, since stderr is non-tty # skip progress messages, since stderr is non-tty
git push -u upstream master >out 2>err && git push -u upstream master >out 2>err &&
! grep "Writing objects" err test_i18ngrep ! "Writing objects" err
' '
test_expect_success 'progress messages go to non-tty (forced)' ' test_expect_success 'progress messages go to non-tty (forced)' '
@ -98,15 +98,15 @@ test_expect_success TTY 'push -q suppresses progress' '
ensure_fresh_upstream && ensure_fresh_upstream &&
test_terminal git push -u -q upstream master >out 2>err && test_terminal git push -u -q upstream master >out 2>err &&
! grep "Writing objects" err test_i18ngrep ! "Writing objects" err
' '
test_expect_success TTY 'push --no-progress suppresses progress' ' test_expect_success TTY 'push --no-progress suppresses progress' '
ensure_fresh_upstream && ensure_fresh_upstream &&
test_terminal git push -u --no-progress upstream master >out 2>err && test_terminal git push -u --no-progress upstream master >out 2>err &&
! grep "Unpacking objects" err && test_i18ngrep ! "Unpacking objects" err &&
! grep "Writing objects" err test_i18ngrep ! "Writing objects" err
' '
test_expect_success TTY 'quiet push' ' test_expect_success TTY 'quiet push' '