undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

gitweb: Fix setting $/ in parse_commit()

Browse Source 
If the commit couldn't have been read, $/ wasn't restored to \n properly,
causing random havoc like git_get_ref_list() returning the ref names with
trailing \n.

Aside of potential confusion in the body of git_search(), no other $/
surprises are hopefully hidden in the code.

Signed-off-by: Petr Baudis <pasky@suse.cz>
Signed-off-by: Junio C Hamano <junkio@cox.net>
This commit is contained in:
Petr Baudis 2006-10-24 02:39:14 +02:00 committed by Junio C Hamano
parent 83543a24c3
commit a153adf683
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
gitweb/gitweb.perl
View File

@ -1009,12 +1009,11 @@ sub parse_commit {
if (defined $commit_text) { if (defined $commit_text) {
@commit_lines = @$commit_text; @commit_lines = @$commit_text;
} else { } else {
$/ = "\0"; local $/ = "\0";
open my $fd, "-|", git_cmd(), "rev-list", "--header", "--parents", "--max-count=1", $commit_id open my $fd, "-|", git_cmd(), "rev-list", "--header", "--parents", "--max-count=1", $commit_id
or return; or return;
@commit_lines = split '\n', <$fd>; @commit_lines = split '\n', <$fd>;
close $fd or return; close $fd or return;
$/ = "\n";
pop @commit_lines; pop @commit_lines;
} }
my $header = shift @commit_lines; my $header = shift @commit_lines;