undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

name-rev.c: use strbuf_getline instead of limited size buffer

Browse Source 
Using a buffer limited to 2048 is unnecessarily limiting. Switch to
using a string buffer to read in stdin for annotation.

Signed-off-by: "John Cai" <johncai86@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
John Cai 2022-01-05 23:29:32 +00:00 committed by Junio C Hamano
parent 34ae3b7071
commit a2585719b3
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
builtin/name-rev.c
View File

@ -623,14 +623,13 @@ int cmd_name_rev(int argc, const char **argv, const char *prefix)
name_tips();
if (annotate_stdin) {
char buffer[2048];
struct strbuf sb = STRBUF_INIT;
while (!feof(stdin)) {
char *p = fgets(buffer, sizeof(buffer), stdin);
if (!p)
break;
name_rev_line(p, &data);
while (strbuf_getline(&sb, stdin) != EOF) {
strbuf_addch(&sb, '\n');
name_rev_line(sb.buf, &data);
}
strbuf_release(&sb);
} else if (all) {
int i, max;