undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

config: drop unused parameter from maybe_remove_section()

Browse Source 
We don't need the contents buffer to drop a section; the parse
information in the config_store_data parameter is enough for our logic.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Jeff King 2019-01-24 08:12:32 -05:00 committed by Junio C Hamano
parent 3d42034a18
commit a263ea84d1
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
config.c
View File

@ -2565,7 +2565,6 @@ static ssize_t write_pair(int fd, const char *key, const char *value,
* entry (which all are to be removed). * entry (which all are to be removed).
*/ */
static void maybe_remove_section(struct config_store_data *store, static void maybe_remove_section(struct config_store_data *store,
const char *contents,
size_t *begin_offset, size_t *end_offset, size_t *begin_offset, size_t *end_offset,
int *seen_ptr) int *seen_ptr)
{ {
@ -2850,7 +2849,7 @@ int git_config_set_multivar_in_file_gently(const char *config_filename,
replace_end = store.parsed[j].end; replace_end = store.parsed[j].end;
copy_end = store.parsed[j].begin; copy_end = store.parsed[j].begin;
if (!value) if (!value)
maybe_remove_section(&store, contents, maybe_remove_section(&store,
&copy_end, &copy_end,
&replace_end, &i); &replace_end, &i);
/* /*