undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

git-svn: do not reuse caches memoized for a different architecture

Browse Source 
Reusing cached data speeds up git-svn by quite a fair bit. However, if
the YAML module is unavailable, the caches are written to disk in an
architecture-dependent manner. That leads to problems when upgrading,
say, from 32-bit to 64-bit Git for Windows.

Let's just try to read those caches back if we detect the absence of the
YAML module and the presence of the file, and delete the file if it
could not be read back correctly.

Note that the only way to catch the error when the memoized cache could
not be read back is to put the call inside an `eval { ... }` block
because it would die otherwise; the `eval` block should also return `1`
in case of success explicitly since the function reading back the cached
data does not return an appropriate value to test for success.

This fixes https://github.com/git-for-windows/git/issues/233.

[ew: import "retrieve" explictly, check unlink result]

Signed-off-by: Gavin Lambert <github@mirality.co.nz>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Eric Wong <e@80x24.org>
This commit is contained in:
Gavin Lambert 2016-10-25 17:30:11 +02:00 committed by Eric Wong
parent 2cc2e70264
commit a2c761ce5b
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
perl/Git/SVN.pm
View File

@ -1658,7 +1658,17 @@ sub tie_for_persistent_memoization {
if ($memo_backend > 0) {
tie %$hash => 'Git::SVN::Memoize::YAML', "$path.yaml";
} else {
tie %$hash => 'Memoize::Storable', "$path.db", 'nstore';
# first verify that any existing file can actually be loaded
# (it may have been saved by an incompatible version)
my $db = "$path.db";
if (-e $db) {
use Storable qw(retrieve);
if (!eval { retrieve($db); 1 }) {
unlink $db or die "unlink $db failed: $!";
}
}
tie %$hash => 'Memoize::Storable', $db, 'nstore';
}
}