undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge branch 'mm/detach-at-HEAD-reflog'

Browse Source 
After "git checkout --detach", "git status" reported a fairly
useless "HEAD detached at HEAD", instead of saying at which exact
commit.

* mm/detach-at-HEAD-reflog:
  status: don't say 'HEAD detached at HEAD'
  t3203: test 'detached at' after checkout --detach
This commit is contained in:
Junio C Hamano 2015-10-15 15:43:42 -07:00
commit a394b39726
2 changed files with 19 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
t/t3203-branch-output.sh
View File

@ -106,6 +106,19 @@ EOF
test_i18ncmp expect actual test_i18ncmp expect actual
' '
test_expect_success 'git branch shows detached HEAD properly after checkout --detach' '
git checkout master &&
cat >expect <<EOF &&
* (HEAD detached at $(git rev-parse --short HEAD^0))
branch-one
branch-two
master
EOF
git checkout --detach &&
git branch >actual &&
test_i18ncmp expect actual
'
test_expect_success 'git branch shows detached HEAD properly after moving' ' test_expect_success 'git branch shows detached HEAD properly after moving' '
cat >expect <<EOF && cat >expect <<EOF &&
* (HEAD detached from $(git rev-parse --short HEAD)) * (HEAD detached from $(git rev-parse --short HEAD))

6
wt-status.c
View File

@ -1319,6 +1319,12 @@ static int grab_1st_switch(unsigned char *osha1, unsigned char *nsha1,
hashcpy(cb->nsha1, nsha1); hashcpy(cb->nsha1, nsha1);
for (end = target; *end && *end != '\n'; end++) for (end = target; *end && *end != '\n'; end++)
; ;
if (!memcmp(target, "HEAD", end - target)) {
/* HEAD is relative. Resolve it to the right reflog entry. */
strbuf_addstr(&cb->buf,
find_unique_abbrev(nsha1, DEFAULT_ABBREV));
return 1;
}
strbuf_add(&cb->buf, target, end - target); strbuf_add(&cb->buf, target, end - target);
return 1; return 1;
} }