undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

http: drop the check for an empty proxy password before approving

Browse Source 
credential_approve() already checks for a non-empty password before
saving, so there's no need to do the extra check here.

Signed-off-by: John Szakmeister <john@szakmeister.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
John Szakmeister 2021-03-11 21:40:27 -05:00 committed by Junio C Hamano
parent cd27f604e4
commit a4a4439fdf
1 changed files with 1 additions and 2 deletions

3
http.c
View File

@ -1635,8 +1635,7 @@ static int handle_curl_result(struct slot_results *results)
if (results->curl_result == CURLE_OK) {
credential_approve(&http_auth);
if (proxy_auth.password)
credential_approve(&proxy_auth);
credential_approve(&proxy_auth);
credential_approve(&cert_auth);
return HTTP_OK;
} else if (results->curl_result == CURLE_SSL_CERTPROBLEM) {