undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

submodule: change string_list changed_submodule_paths

Browse Source 
Eliminate a call to 'xstrdup()' by changing the string_list
'changed_submodule_paths' to duplicated strings added to it.

Signed-off-by: Brandon Williams <bmwill@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Brandon Williams 2017-04-28 16:54:00 -07:00 committed by Junio C Hamano
parent d1a8460caa
commit a6bb78c3b1
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
submodule.c
View File

@ -20,7 +20,7 @@
static int config_fetch_recurse_submodules = RECURSE_SUBMODULES_ON_DEMAND; static int config_fetch_recurse_submodules = RECURSE_SUBMODULES_ON_DEMAND;
static int config_update_recurse_submodules = RECURSE_SUBMODULES_DEFAULT; static int config_update_recurse_submodules = RECURSE_SUBMODULES_DEFAULT;
static int parallel_jobs = 1; static int parallel_jobs = 1;
static struct string_list changed_submodule_paths = STRING_LIST_INIT_NODUP; static struct string_list changed_submodule_paths = STRING_LIST_INIT_DUP;
static int initialized_fetch_ref_tips; static int initialized_fetch_ref_tips;
static struct oid_array ref_tips_before_fetch; static struct oid_array ref_tips_before_fetch;
static struct oid_array ref_tips_after_fetch; static struct oid_array ref_tips_after_fetch;
@ -939,7 +939,7 @@ static void submodule_collect_changed_cb(struct diff_queue_struct *q,
struct string_list_item *path; struct string_list_item *path;
path = unsorted_string_list_lookup(&changed_submodule_paths, p->two->path); path = unsorted_string_list_lookup(&changed_submodule_paths, p->two->path);
if (!path && !is_submodule_commit_present(p->two->path, p->two->oid.hash)) if (!path && !is_submodule_commit_present(p->two->path, p->two->oid.hash))
string_list_append(&changed_submodule_paths, xstrdup(p->two->path)); string_list_append(&changed_submodule_paths, p->two->path);
} else { } else {
/* Submodule is new or was moved here */ /* Submodule is new or was moved here */
/* NEEDSWORK: When the .git directories of submodules /* NEEDSWORK: When the .git directories of submodules