undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

git-commit: don't add multiple Signed-off-by: from the same identity

Browse Source 
If requested to signoff a commit, don't add another Signed-off-by: line
to the commit message if the exact same line is already there.

This was noticed and requested by Josh Triplett through
 http://bugs.debian.org/430851

Signed-off-by: Gerrit Pape <pape@smarden.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Gerrit Pape 2007-07-06 14:42:27 +00:00 committed by Junio C Hamano
parent 4017761fd8
commit a7342913e2
1 changed files with 11 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
git-commit.sh
View File

@ -458,16 +458,18 @@ fi | git stripspace >"$GIT_DIR"/COMMIT_EDITMSG
case "$signoff" in case "$signoff" in
t) t)
need_blank_before_signoff= sign=$(git-var GIT_COMMITTER_IDENT | sed -e '
s/>.*/>/
s/^/Signed-off-by: /
')
blank_before_signoff=
tail -n 1 "$GIT_DIR"/COMMIT_EDITMSG | tail -n 1 "$GIT_DIR"/COMMIT_EDITMSG |
grep 'Signed-off-by:' >/dev/null || need_blank_before_signoff=yes grep 'Signed-off-by:' >/dev/null || blank_before_signoff='
{ '
test -z "$need_blank_before_signoff" || echo tail -n 1 "$GIT_DIR"/COMMIT_EDITMSG |
git-var GIT_COMMITTER_IDENT | sed -e ' grep "$sign"$ >/dev/null ||
s/>.*/>/ printf '%s%s\n' "$blank_before_signoff" "$sign" \
s/^/Signed-off-by: / >>"$GIT_DIR"/COMMIT_EDITMSG
'
} >>"$GIT_DIR"/COMMIT_EDITMSG
;; ;;
esac esac