undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

t5608-clone-2gb.sh: turn GIT_TEST_CLONE_2GB into a bool

Browse Source 
The GIT_TEST_CLONE_2GB environment variable is only ever checked with
'test -z' in 't5608-clone-2gb.sh', so any non-empty value is
interpreted as "yes, run these expensive tests", even
'GIT_TEST_CLONE_2GB=NoThanks'.

Similar GIT_TEST_* environment variables have already been turned into
bools in 3b072c577b (tests: replace test_tristate with "git
env--helper", 2019-06-21), so let's turn GIT_TEST_CLONE_2GB into a
bool as well, to follow suit.

Our CI builds set GIT_TEST_CLONE_2GB=YesPlease, so adjust them
accordingly, thus removing the last 'YesPlease' from our CI scripts.

Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
SZEDER Gábor 2019-11-22 14:14:37 +01:00 committed by Junio C Hamano
parent 43a2afee82
commit a85efb5985
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ci/lib.sh
View File

@ -156,7 +156,7 @@ fi
export DEVELOPER=1 export DEVELOPER=1
export DEFAULT_TEST_TARGET=prove export DEFAULT_TEST_TARGET=prove
export GIT_TEST_CLONE_2GB=YesPlease export GIT_TEST_CLONE_2GB=true
case "$jobname" in case "$jobname" in
linux-clang|linux-gcc) linux-clang|linux-gcc)

2
t/t5608-clone-2gb.sh
View File

@ -3,7 +3,7 @@
test_description='Test cloning a repository larger than 2 gigabyte' test_description='Test cloning a repository larger than 2 gigabyte'
. ./test-lib.sh . ./test-lib.sh
if test -z "$GIT_TEST_CLONE_2GB" if ! test_bool_env GIT_TEST_CLONE_2GB false
then then
say 'Skipping expensive 2GB clone test; enable it with GIT_TEST_CLONE_2GB=t' say 'Skipping expensive 2GB clone test; enable it with GIT_TEST_CLONE_2GB=t'
else else