undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

test-tool: help verifying BUG() code paths

Browse Source 
When we call BUG(), we signal via SIGABRT that something bad happened,
dumping cores if so configured. In some setups these coredumps are
redirected to some central place such as /proc/sys/kernel/core_pattern,
which is a good thing.

However, when we try to verify in our test suite that bugs are caught in
certain code paths, we do *not* want to clutter such a central place
with unnecessary coredumps.

So let's special-case the test helpers (which we use to verify such code
paths) so that the BUG() calls will *not* call abort() but exit with a
special-purpose exit code instead.

Helped-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Johannes Schindelin 2018-05-02 11:38:28 +02:00 committed by Junio C Hamano
parent 1f1cddd558
commit a86303cb5d
2 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
t/helper/test-tool.c
View File

@ -47,7 +47,9 @@ static struct test_cmd cmds[] = {
int cmd_main(int argc, const char **argv) int cmd_main(int argc, const char **argv)
{ {
int i; int i;
extern int BUG_exit_code;
BUG_exit_code = 99;
if (argc < 2) if (argc < 2)
die("I need a test name!"); die("I need a test name!");

5
usage.c
View File

@ -210,6 +210,9 @@ void warning(const char *warn, ...)
va_end(params); va_end(params);
} }
/* Only set this, ever, from t/helper/, when verifying that bugs are caught. */
int BUG_exit_code;
static NORETURN void BUG_vfl(const char *file, int line, const char *fmt, va_list params) static NORETURN void BUG_vfl(const char *file, int line, const char *fmt, va_list params)
{ {
char prefix[256]; char prefix[256];
@ -221,6 +224,8 @@ static NORETURN void BUG_vfl(const char *file, int line, const char *fmt, va_lis
snprintf(prefix, sizeof(prefix), "BUG: "); snprintf(prefix, sizeof(prefix), "BUG: ");
vreportf(prefix, fmt, params); vreportf(prefix, fmt, params);
if (BUG_exit_code)
exit(BUG_exit_code);
abort(); abort();
} }