undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't dereference a strdup-returned NULL

Browse Source 
There are only a dozen or so uses of strdup in all of git.
Of those, most seem ok, but this one isn't:

Signed-off-by: Jim Meyering <jim@meyering.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Jim Meyering 2007-06-12 22:59:21 +02:00 committed by Junio C Hamano
parent c43f64a0af
commit aa32eedc69
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
remote.c
View File

@ -542,7 +542,7 @@ int match_refs(struct ref *src, struct ref *dst, struct ref ***dst_tail,
strcpy(dst_name, pat->dst); strcpy(dst_name, pat->dst);
strcat(dst_name, src->name + strlen(pat->src)); strcat(dst_name, src->name + strlen(pat->src));
} else } else
dst_name = strdup(src->name); dst_name = xstrdup(src->name);
dst_peer = find_ref_by_name(dst, dst_name); dst_peer = find_ref_by_name(dst, dst_name);
if (dst_peer && dst_peer->peer_ref) if (dst_peer && dst_peer->peer_ref)
/* We're already sending something to this ref. */ /* We're already sending something to this ref. */