undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge branch 'js/misc-fixes' into maint

Browse Source 
Various compilation fixes and squelching of warnings.

* js/misc-fixes:
  Correct fscanf formatting string for I64u values
  Silence GCC's "cast of pointer to integer of a different size" warning
  Squelch warning about an integer overflow
This commit is contained in:
Junio C Hamano 2015-11-05 12:18:13 -08:00
commit ace5348dcb
5 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
builtin/gc.c
View File

@ -240,7 +240,7 @@ static const char *lock_repo_for_gc(int force, pid_t* ret_pid)
* running. * running.
*/ */
time(NULL) - st.st_mtime <= 12 * 3600 && time(NULL) - st.st_mtime <= 12 * 3600 &&
fscanf(fp, "%"PRIuMAX" %127c", &pid, locking_host) == 2 && fscanf(fp, "%"SCNuMAX" %127c", &pid, locking_host) == 2 &&
/* be gentle to concurrent "gc" on remote hosts */ /* be gentle to concurrent "gc" on remote hosts */
(strcmp(locking_host, my_host) || !kill(pid, 0) || errno == EPERM); (strcmp(locking_host, my_host) || !kill(pid, 0) || errno == EPERM);
if (fp != NULL) if (fp != NULL)

6
compat/regex/regcomp.c
View File

@ -18,6 +18,8 @@
Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
02110-1301 USA. */ 02110-1301 USA. */
#include <stdint.h>
static reg_errcode_t re_compile_internal (regex_t *preg, const char * pattern, static reg_errcode_t re_compile_internal (regex_t *preg, const char * pattern,
size_t length, reg_syntax_t syntax); size_t length, reg_syntax_t syntax);
static void re_compile_fastmap_iter (regex_t *bufp, static void re_compile_fastmap_iter (regex_t *bufp,
@ -2577,7 +2579,7 @@ parse_dup_op (bin_tree_t *elem, re_string_t *regexp, re_dfa_t *dfa,
old_tree = NULL; old_tree = NULL;
if (elem->token.type == SUBEXP) if (elem->token.type == SUBEXP)
postorder (elem, mark_opt_subexp, (void *) (long) elem->token.opr.idx); postorder (elem, mark_opt_subexp, (void *) (intptr_t) elem->token.opr.idx);
tree = create_tree (dfa, elem, NULL, (end == -1 ? OP_DUP_ASTERISK : OP_ALT)); tree = create_tree (dfa, elem, NULL, (end == -1 ? OP_DUP_ASTERISK : OP_ALT));
if (BE (tree == NULL, 0)) if (BE (tree == NULL, 0))
@ -3806,7 +3808,7 @@ create_token_tree (re_dfa_t *dfa, bin_tree_t *left, bin_tree_t *right,
static reg_errcode_t static reg_errcode_t
mark_opt_subexp (void *extra, bin_tree_t *node) mark_opt_subexp (void *extra, bin_tree_t *node)
{ {
int idx = (int) (long) extra; int idx = (int) (intptr_t) extra;
if (node->token.type == SUBEXP && node->token.opr.idx == idx) if (node->token.type == SUBEXP && node->token.opr.idx == idx)
node->token.opt_subexp = 1; node->token.opt_subexp = 1;

6
git-compat-util.h
View File

@ -296,6 +296,10 @@ extern char *gitbasename(char *);
#define PRIuMAX "llu" #define PRIuMAX "llu"
#endif #endif
#ifndef SCNuMAX
#define SCNuMAX PRIuMAX
#endif
#ifndef PRIu32 #ifndef PRIu32
#define PRIu32 "u" #define PRIu32 "u"
#endif #endif
@ -568,7 +572,7 @@ extern int git_lstat(const char *, struct stat *);
#endif #endif
#define DEFAULT_PACKED_GIT_LIMIT \ #define DEFAULT_PACKED_GIT_LIMIT \
((1024L * 1024L) * (sizeof(void*) >= 8 ? 8192 : 256)) ((1024L * 1024L) * (size_t)(sizeof(void*) >= 8 ? 8192 : 256))
#ifdef NO_PREAD #ifdef NO_PREAD
#define pread git_pread #define pread git_pread

2
pack-revindex.c
View File

@ -21,7 +21,7 @@ static int pack_revindex_hashsz;
static int pack_revindex_ix(struct packed_git *p) static int pack_revindex_ix(struct packed_git *p)
{ {
unsigned long ui = (unsigned long)p; unsigned long ui = (unsigned long)(intptr_t)p;
int i; int i;
ui = ui ^ (ui >> 16); /* defeat structure alignment */ ui = ui ^ (ui >> 16); /* defeat structure alignment */

2
sha1_file.c
View File

@ -2137,7 +2137,7 @@ static unsigned long pack_entry_hash(struct packed_git *p, off_t base_offset)
{ {
unsigned long hash; unsigned long hash;
hash = (unsigned long)p + (unsigned long)base_offset; hash = (unsigned long)(intptr_t)p + (unsigned long)base_offset;
hash += (hash >> 8) + (hash >> 16); hash += (hash >> 8) + (hash >> 16);
return hash % MAX_DELTA_CACHE; return hash % MAX_DELTA_CACHE;
} }