undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

banned.h: mark strncat() as banned

Browse Source 
strncat() has the same quadratic behavior as strcat() and is
difficult-to-read and bug-prone.  While it hasn't yet been a
problem in git iself, strncat() found it's way into 'master'
of cgit and caused segfaults on my system.

Signed-off-by: Eric Wong <e@80x24.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Eric Wong 2019-01-02 09:38:46 +00:00 committed by Junio C Hamano
parent 0d0ac3826a
commit ace5707a80
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
banned.h
View File

@ -16,6 +16,8 @@
#define strcat(x,y) BANNED(strcat) #define strcat(x,y) BANNED(strcat)
#undef strncpy #undef strncpy
#define strncpy(x,y,n) BANNED(strncpy) #define strncpy(x,y,n) BANNED(strncpy)
#undef strncat
#define strncat(x,y,n) BANNED(strncat)
#undef sprintf #undef sprintf
#undef vsprintf #undef vsprintf