undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Explicitly set X to avoid potential build breakage

Browse Source 
$X is appended to binary names for Windows builds (ie. git.exe).
Pollution from the environment can inadvertently trigger this behaviour,
resulting in 'git' turning into 'gitwhatever' without warning.

Signed-off-by: Michael Palimaka <kensington@astralcloak.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Michael Palimaka 2012-02-08 21:59:04 +11:00 committed by Junio C Hamano
parent d0482e88a7
commit ace5e97ecd
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Makefile
View File

@ -428,6 +428,9 @@ PROGRAM_OBJS += upload-pack.o
PROGRAM_OBJS += http-backend.o PROGRAM_OBJS += http-backend.o
PROGRAM_OBJS += sh-i18n--envsubst.o PROGRAM_OBJS += sh-i18n--envsubst.o
# Binary suffix, set to .exe for Windows builds
X =
PROGRAMS += $(patsubst %.o,git-%$X,$(PROGRAM_OBJS)) PROGRAMS += $(patsubst %.o,git-%$X,$(PROGRAM_OBJS))
TEST_PROGRAMS_NEED_X += test-chmtime TEST_PROGRAMS_NEED_X += test-chmtime