undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

git-pickaxe: tighten sanity checks.

Browse Source 
When compiled for debugging, make sure that refcnt sanity check
code detects underflows in origin reference counting.

Signed-off-by: Junio C Hamano <junkio@cox.net>
This commit is contained in:
Junio C Hamano 2006-10-30 14:27:52 -08:00
parent f5f75c652b
commit ae86ad6575
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
builtin-pickaxe.c
View File

@ -973,7 +973,9 @@ static void assign_blame(struct scoreboard *sb, struct rev_info *revs, int opt)
if (!cmp_suspect(ent->suspect, suspect)) if (!cmp_suspect(ent->suspect, suspect))
ent->guilty = 1; ent->guilty = 1;
origin_decref(suspect); origin_decref(suspect);
coalesce(sb);
if (DEBUG) /* sanity */
sanity_check_refcnt(sb);
} }
} }
@ -1341,11 +1343,14 @@ static void sanity_check_refcnt(struct scoreboard *sb)
struct blame_entry *ent; struct blame_entry *ent;
for (ent = sb->ent; ent; ent = ent->next) { for (ent = sb->ent; ent; ent = ent->next) {
/* first mark the ones that haven't been checked */ /* Nobody should have zero or negative refcnt */
if (ent->suspect->refcnt <= 0)
baa = 1;
}
for (ent = sb->ent; ent; ent = ent->next) {
/* Mark the ones that haven't been checked */
if (0 < ent->suspect->refcnt) if (0 < ent->suspect->refcnt)
ent->suspect->refcnt = -ent->suspect->refcnt; ent->suspect->refcnt = -ent->suspect->refcnt;
else if (!ent->suspect->refcnt)
baa = 1;
} }
for (ent = sb->ent; ent; ent = ent->next) { for (ent = sb->ent; ent; ent = ent->next) {
/* then pick each and see if they have the the /* then pick each and see if they have the the
@ -1357,7 +1362,7 @@ static void sanity_check_refcnt(struct scoreboard *sb)
if (0 < suspect->refcnt) if (0 < suspect->refcnt)
continue; continue;
suspect->refcnt = -suspect->refcnt; suspect->refcnt = -suspect->refcnt; /* Unmark */
for (found = 0, e = sb->ent; e; e = e->next) { for (found = 0, e = sb->ent; e; e = e->next) {
if (e->suspect != suspect) if (e->suspect != suspect)
continue; continue;