undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

gitweb: generate project/action/hash URLs

Browse Source 
When generating path info URLs, reduce the number of CGI parameters by
embedding action and hash_parent:filename or hash in the path.

Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Acked-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Giuseppe Bilotta 2008-10-21 21:34:51 +02:00 committed by Junio C Hamano
parent d8c2882254
commit b02bd7a632
1 changed files with 30 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
gitweb/gitweb.perl
View File

@ -731,14 +731,41 @@ sub href (%) {
my ($use_pathinfo) = gitweb_check_feature('pathinfo'); my ($use_pathinfo) = gitweb_check_feature('pathinfo');
if ($use_pathinfo) { if ($use_pathinfo) {
# use PATH_INFO for project name # try to put as many parameters as possible in PATH_INFO:
# - project name
# - action
# - hash or hash_base:filename
# When the script is the root DirectoryIndex for the domain,
# $href here would be something like http://gitweb.example.com/
# Thus, we strip any trailing / from $href, to spare us double
# slashes in the final URL
$href =~ s,/$,,;
# Then add the project name, if present
$href .= "/".esc_url($params{'project'}) if defined $params{'project'}; $href .= "/".esc_url($params{'project'}) if defined $params{'project'};
delete $params{'project'}; delete $params{'project'};
# Summary just uses the project path URL # Summary just uses the project path URL, any other action is
if (defined $params{'action'} && $params{'action'} eq 'summary') { # added to the URL
if (defined $params{'action'}) {
$href .= "/".esc_url($params{'action'}) unless $params{'action'} eq 'summary';
delete $params{'action'}; delete $params{'action'};
} }
# Finally, we put either hash_base:file_name or hash
if (defined $params{'hash_base'}) {
$href .= "/".esc_url($params{'hash_base'});
if (defined $params{'file_name'}) {
$href .= ":".esc_url($params{'file_name'});
delete $params{'file_name'};
}
delete $params{'hash'};
delete $params{'hash_base'};
} elsif (defined $params{'hash'}) {
$href .= "/".esc_url($params{'hash'});
delete $params{'hash'};
}
} }
# now encode the parameters explicitly # now encode the parameters explicitly