undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

write_entry: fix leak when retrying delayed filter

Browse Source 
When write_entry() retries a delayed filter request, we
don't need to send the blob content to the filter again, and
set the pointer to NULL. But doing so means we leak the
contents we read earlier from read_blob_entry(). Let's make
sure to free it before dropping the pointer.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Jeff King 2017-10-09 13:48:24 -04:00 committed by Junio C Hamano
parent 11179eb311
commit b2401586fc
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
entry.c
View File

@ -283,6 +283,7 @@ static int write_entry(struct cache_entry *ce,
if (dco && dco->state != CE_NO_DELAY) { if (dco && dco->state != CE_NO_DELAY) {
/* Do not send the blob in case of a retry. */ /* Do not send the blob in case of a retry. */
if (dco->state == CE_RETRY) { if (dco->state == CE_RETRY) {
free(new);
new = NULL; new = NULL;
size = 0; size = 0;
} }