cmd_fetch_pack(): simplify computation of return value
Set the final value at initialization rather than initializing it then sometimes changing it. Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
parent
778e7543d2
commit
b285668dd2
@ -1020,17 +1020,16 @@ int cmd_fetch_pack(int argc, const char **argv, const char *prefix)
|
||||
if (finish_connect(conn))
|
||||
return 1;
|
||||
|
||||
ret = !ref;
|
||||
if (sought.nr) {
|
||||
/* If the heads to pull were given, we should have
|
||||
* consumed all of them by matching the remote.
|
||||
* Otherwise, 'git fetch remote no-such-ref' would
|
||||
* silently succeed without issuing an error.
|
||||
*/
|
||||
for (i = 0; i < sought.nr; i++)
|
||||
error("no such remote ref %s", sought.items[i].string);
|
||||
ret = 1;
|
||||
}
|
||||
ret = !ref || sought.nr;
|
||||
|
||||
/*
|
||||
* If the heads to pull were given, we should have consumed
|
||||
* all of them by matching the remote. Otherwise, 'git fetch
|
||||
* remote no-such-ref' would silently succeed without issuing
|
||||
* an error.
|
||||
*/
|
||||
for (i = 0; i < sought.nr; i++)
|
||||
error("no such remote ref %s", sought.items[i].string);
|
||||
while (ref) {
|
||||
printf("%s %s\n",
|
||||
sha1_to_hex(ref->old_sha1), ref->name);
|
||||
|
Loading…
Reference in New Issue
Block a user