undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Avoid writing to buffer in add_excludes_from_file_1()

Browse Source 
In the next patch, the buffer that is being used within
add_excludes_from_file_1() comes from another function and does not
have extra space to put \n at the end.

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Nguyễn Thái Ngọc Duy 2009-08-20 20:47:00 +07:00 committed by Junio C Hamano
parent 5203083694
commit b5041c5f3b
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
dir.c
View File

@ -229,10 +229,9 @@ static int add_excludes_from_file_1(const char *fname,
if (buf_p) if (buf_p)
*buf_p = buf; *buf_p = buf;
buf[size++] = '\n';
entry = buf; entry = buf;
for (i = 0; i < size; i++) { for (i = 0; i <= size; i++) {
if (buf[i] == '\n') { if (i == size || buf[i] == '\n') {
if (entry != buf + i && entry[0] != '#') { if (entry != buf + i && entry[0] != '#') {
buf[i - (i && buf[i-1] == '\r')] = 0; buf[i - (i && buf[i-1] == '\r')] = 0;
add_exclude(entry, base, baselen, which); add_exclude(entry, base, baselen, which);