undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

test-path-utils: Fix off by one, found by valgrind

Browse Source 
When normalizing an absolute path, we might have to add a slash _and_ a
NUL to the buffer, so the buffer was one too small.

Let's just future proof the code and alloc PATH_MAX + 1 bytes.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Johannes Schindelin 2009-01-28 00:07:36 +01:00 committed by Junio C Hamano
parent f265458f61
commit b8469ad057
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test-path-utils.c
View File

@ -3,7 +3,7 @@
int main(int argc, char **argv) int main(int argc, char **argv)
{ {
if (argc == 3 && !strcmp(argv[1], "normalize_absolute_path")) { if (argc == 3 && !strcmp(argv[1], "normalize_absolute_path")) {
char *buf = xmalloc(strlen(argv[2])+1); char *buf = xmalloc(PATH_MAX + 1);
int rv = normalize_absolute_path(buf, argv[2]); int rv = normalize_absolute_path(buf, argv[2]);
assert(strlen(buf) == rv); assert(strlen(buf) == rv);
puts(buf); puts(buf);