undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

git-remote-mediawiki: replace "unless" statements with negated "if" statements

Browse Source 
Signed-off-by: Célestin Matte <celestin.matte@ensimag.fr>
Signed-off-by: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Célestin Matte 2013-06-14 15:50:32 +02:00 committed by Junio C Hamano
parent e83d36b66f
commit b8b4e1b385
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
contrib/mw-to-git/git-remote-mediawiki.perl
View File

@ -82,11 +82,11 @@ $shallow_import = ($shallow_import eq 'true');
# - by_rev: perform one query per new revision on the remote wiki # - by_rev: perform one query per new revision on the remote wiki
# - by_page: query each tracked page for new revision # - by_page: query each tracked page for new revision
my $fetch_strategy = run_git("config --get remote.${remotename}.fetchStrategy"); my $fetch_strategy = run_git("config --get remote.${remotename}.fetchStrategy");
unless ($fetch_strategy) { if (!$fetch_strategy) {
$fetch_strategy = run_git('config --get mediawiki.fetchStrategy'); $fetch_strategy = run_git('config --get mediawiki.fetchStrategy');
} }
chomp($fetch_strategy); chomp($fetch_strategy);
unless ($fetch_strategy) { if (!$fetch_strategy) {
$fetch_strategy = 'by_page'; $fetch_strategy = 'by_page';
} }
@ -108,7 +108,7 @@ my %basetimestamps;
# deterministic, this means everybody gets the same sha1 for each # deterministic, this means everybody gets the same sha1 for each
# MediaWiki revision. # MediaWiki revision.
my $dumb_push = run_git("config --get --bool remote.${remotename}.dumbPush"); my $dumb_push = run_git("config --get --bool remote.${remotename}.dumbPush");
unless ($dumb_push) { if (!$dumb_push) {
$dumb_push = run_git('config --get --bool mediawiki.dumbPush'); $dumb_push = run_git('config --get --bool mediawiki.dumbPush');
} }
chomp($dumb_push); chomp($dumb_push);
@ -667,7 +667,7 @@ sub fetch_mw_revisions_for_page {
push(@page_revs, $page_rev_ids); push(@page_revs, $page_rev_ids);
$revnum++; $revnum++;
} }
last unless $result->{'query-continue'}; last if (!$result->{'query-continue'});
$query->{rvstartid} = $result->{'query-continue'}->{revisions}->{rvstartid}; $query->{rvstartid} = $result->{'query-continue'}->{revisions}->{rvstartid};
} }
if ($shallow_import && @page_revs) { if ($shallow_import && @page_revs) {
@ -1239,7 +1239,7 @@ sub mw_push_revision {
die("Unknown error from mw_push_file()\n"); die("Unknown error from mw_push_file()\n");
} }
} }
unless ($dumb_push) { if (!$dumb_push) {
run_git(qq(notes --ref=${remotename}/mediawiki add -f -m "mediawiki_revision: ${mw_revision}" ${sha1_commit})); run_git(qq(notes --ref=${remotename}/mediawiki add -f -m "mediawiki_revision: ${mw_revision}" ${sha1_commit}));
run_git(qq(update-ref -m "Git-MediaWiki push" refs/mediawiki/${remotename}/master ${sha1_commit} ${sha1_child})); run_git(qq(update-ref -m "Git-MediaWiki push" refs/mediawiki/${remotename}/master ${sha1_commit} ${sha1_child}));
} }
@ -1320,7 +1320,7 @@ sub get_mw_namespace_id {
my $ns = $namespace_id{$name}; my $ns = $namespace_id{$name};
my $id; my $id;
unless (defined $ns) { if (!defined $ns) {
print {*STDERR} "No such namespace ${name} on MediaWiki.\n"; print {*STDERR} "No such namespace ${name} on MediaWiki.\n";
$ns = {is_namespace => 0}; $ns = {is_namespace => 0};
$namespace_id{$name} = $ns; $namespace_id{$name} = $ns;