undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

builtin-clone: rewrite guess_dir_name()

Browse Source 
The function has to do three small and independent tasks, but all of them
were crammed into a single loop. This rewrites the function entirely by
unrolling these tasks.

We also now use is_dir_sep(c) instead of c == '/' to increase portability.

Signed-off-by: Johannes Sixt <johannes.sixt@telecom.at>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Johannes Sixt 2008-07-19 11:32:45 +02:00 committed by Junio C Hamano
parent fe77b6959c
commit b8c5db35fc
1 changed files with 30 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

57
builtin-clone.c
View File

@ -95,35 +95,38 @@ static char *get_repo_path(const char *repo, int *is_bundle)
static char *guess_dir_name(const char *repo, int is_bundle) static char *guess_dir_name(const char *repo, int is_bundle)
{ {
const char *p, *start, *end, *limit; const char *end = repo + strlen(repo), *start;
int after_slash_or_colon;
/* Guess dir name from repository: strip trailing '/', /*
* strip trailing '[:/]*.{git,bundle}', strip leading '.*[/:]'. */ * Strip trailing slashes and /.git
*/
after_slash_or_colon = 1; while (repo < end && is_dir_sep(end[-1]))
limit = repo + strlen(repo); end--;
start = repo; if (end - repo > 5 && is_dir_sep(end[-5]) &&
end = limit; !strncmp(end - 4, ".git", 4)) {
for (p = repo; p < limit; p++) { end -= 5;
const char *prefix = is_bundle ? ".bundle" : ".git"; while (repo < end && is_dir_sep(end[-1]))
if (!prefixcmp(p, prefix)) { end--;
if (!after_slash_or_colon)
end = p;
p += strlen(prefix) - 1;
} else if (!prefixcmp(p, ".bundle")) {
if (!after_slash_or_colon)
end = p;
p += 7;
} else if (*p == '/' || *p == ':') {
if (end == limit)
end = p;
after_slash_or_colon = 1;
} else if (after_slash_or_colon) {
start = p;
end = limit;
after_slash_or_colon = 0;
} }
/*
* Find last component, but be prepared that repo could have
* the form "remote.example.com:foo.git", i.e. no slash
* in the directory part.
*/
start = end;
while (repo < start && !is_dir_sep(start[-1]) && start[-1] != ':')
start--;
/*
* Strip .{bundle,git}.
*/
if (is_bundle) {
if (end - start > 7 && !strncmp(end - 7, ".bundle", 7))
end -= 7;
} else {
if (end - start > 4 && !strncmp(end - 4, ".git", 4))
end -= 4;
} }
return xstrndup(start, end - start); return xstrndup(start, end - start);