undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

t9001 (send-email): Do not use hardcoded /bin/sh in test

Browse Source 
Scriptlets used form inside this test began with hardcoded "#!/bin/sh".
By setting SHELL_PATH the user is already telling us that what the vendor
has in /bin/sh isn't POSIX enough, and we really should try to honor that
request.

Originally noticed by SungHyun Nam who later tested this patch and
verified that it fixes the issue on Solaris 9.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Junio C Hamano 2008-07-17 23:18:43 -07:00
parent 72972eb374
commit bb3e4f03be
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
t/t9001-send-email.sh
View File

@ -13,7 +13,7 @@ test_expect_success \
test_expect_success \ test_expect_success \
'Setup helper tool' \ 'Setup helper tool' \
'(echo "#!/bin/sh" '(echo "#!$SHELL_PATH"
echo shift echo shift
echo output=1 echo output=1
echo "while test -f commandline\$output; do output=\$((\$output+1)); done" echo "while test -f commandline\$output; do output=\$((\$output+1)); done"
@ -138,7 +138,7 @@ test_expect_success 'Valid In-Reply-To when prompting' '
' '
test_expect_success 'setup fake editor' ' test_expect_success 'setup fake editor' '
(echo "#!/bin/sh" && (echo "#!$SHELL_PATH" &&
echo "echo fake edit >>\"\$1\"" echo "echo fake edit >>\"\$1\""
) >fake-editor && ) >fake-editor &&
chmod +x fake-editor chmod +x fake-editor
@ -235,7 +235,7 @@ test_expect_success 'sendemail.cc unset' '
test_expect_success '--compose adds MIME for utf8 body' ' test_expect_success '--compose adds MIME for utf8 body' '
clean_fake_sendmail && clean_fake_sendmail &&
(echo "#!/bin/sh" && (echo "#!$SHELL_PATH" &&
echo "echo utf8 body: àéìöú >>\"\$1\"" echo "echo utf8 body: àéìöú >>\"\$1\""
) >fake-editor-utf8 && ) >fake-editor-utf8 &&
chmod +x fake-editor-utf8 && chmod +x fake-editor-utf8 &&
@ -254,7 +254,7 @@ test_expect_success '--compose adds MIME for utf8 body' '
test_expect_success '--compose respects user mime type' ' test_expect_success '--compose respects user mime type' '
clean_fake_sendmail && clean_fake_sendmail &&
(echo "#!/bin/sh" && (echo "#!$SHELL_PATH" &&
echo "(echo MIME-Version: 1.0" echo "(echo MIME-Version: 1.0"
echo " echo Content-Type: text/plain\\; charset=iso-8859-1" echo " echo Content-Type: text/plain\\; charset=iso-8859-1"
echo " echo Content-Transfer-Encoding: 8bit" echo " echo Content-Transfer-Encoding: 8bit"