tree_entry_interesting(): support depth limit
This is needed to replace pathspec_matches() in builtin/grep.c. max_depth == -1 means infinite depth. Depth limit is only effective when pathspec.recursive == 1. When pathspec.recursive == 0, the behavior depends on match functions: non-recursive for tree_entry_interesting() and recursive for match_pathspec{,_depth} Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
parent
58c4d66619
commit
bc96cc87db
2
cache.h
2
cache.h
@ -503,6 +503,8 @@ extern int ie_modified(const struct index_state *, struct cache_entry *, struct
|
|||||||
struct pathspec {
|
struct pathspec {
|
||||||
const char **raw; /* get_pathspec() result, not freed by free_pathspec() */
|
const char **raw; /* get_pathspec() result, not freed by free_pathspec() */
|
||||||
int nr;
|
int nr;
|
||||||
|
int recursive:1;
|
||||||
|
int max_depth;
|
||||||
struct pathspec_item {
|
struct pathspec_item {
|
||||||
const char *match;
|
const char *match;
|
||||||
int len;
|
int len;
|
||||||
|
15
dir.c
15
dir.c
@ -87,6 +87,21 @@ int fill_directory(struct dir_struct *dir, const char **pathspec)
|
|||||||
return len;
|
return len;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
int within_depth(const char *name, int namelen,
|
||||||
|
int depth, int max_depth)
|
||||||
|
{
|
||||||
|
const char *cp = name, *cpe = name + namelen;
|
||||||
|
|
||||||
|
while (cp < cpe) {
|
||||||
|
if (*cp++ != '/')
|
||||||
|
continue;
|
||||||
|
depth++;
|
||||||
|
if (depth > max_depth)
|
||||||
|
return 0;
|
||||||
|
}
|
||||||
|
return 1;
|
||||||
|
}
|
||||||
|
|
||||||
/*
|
/*
|
||||||
* Does 'match' match the given name?
|
* Does 'match' match the given name?
|
||||||
* A match is found if
|
* A match is found if
|
||||||
|
1
dir.h
1
dir.h
@ -65,6 +65,7 @@ struct dir_struct {
|
|||||||
#define MATCHED_FNMATCH 2
|
#define MATCHED_FNMATCH 2
|
||||||
#define MATCHED_EXACTLY 3
|
#define MATCHED_EXACTLY 3
|
||||||
extern int match_pathspec(const char **pathspec, const char *name, int namelen, int prefix, char *seen);
|
extern int match_pathspec(const char **pathspec, const char *name, int namelen, int prefix, char *seen);
|
||||||
|
extern int within_depth(const char *name, int namelen, int depth, int max_depth);
|
||||||
|
|
||||||
extern int fill_directory(struct dir_struct *dir, const char **pathspec);
|
extern int fill_directory(struct dir_struct *dir, const char **pathspec);
|
||||||
extern int read_directory(struct dir_struct *, const char *path, int len, const char **pathspec);
|
extern int read_directory(struct dir_struct *, const char *path, int len, const char **pathspec);
|
||||||
|
@ -146,6 +146,10 @@ int diff_tree(struct tree_desc *t1, struct tree_desc *t2,
|
|||||||
int all_t1_interesting = 0;
|
int all_t1_interesting = 0;
|
||||||
int all_t2_interesting = 0;
|
int all_t2_interesting = 0;
|
||||||
|
|
||||||
|
/* Enable recursion indefinitely */
|
||||||
|
opt->pathspec.recursive = DIFF_OPT_TST(opt, RECURSIVE);
|
||||||
|
opt->pathspec.max_depth = -1;
|
||||||
|
|
||||||
strbuf_init(&base, PATH_MAX);
|
strbuf_init(&base, PATH_MAX);
|
||||||
strbuf_add(&base, base_str, baselen);
|
strbuf_add(&base, base_str, baselen);
|
||||||
|
|
||||||
|
15
tree-walk.c
15
tree-walk.c
@ -1,6 +1,7 @@
|
|||||||
#include "cache.h"
|
#include "cache.h"
|
||||||
#include "tree-walk.h"
|
#include "tree-walk.h"
|
||||||
#include "unpack-trees.h"
|
#include "unpack-trees.h"
|
||||||
|
#include "dir.h"
|
||||||
#include "tree.h"
|
#include "tree.h"
|
||||||
|
|
||||||
static const char *get_mode(const char *str, unsigned int *modep)
|
static const char *get_mode(const char *str, unsigned int *modep)
|
||||||
@ -559,8 +560,13 @@ int tree_entry_interesting(const struct name_entry *entry,
|
|||||||
int pathlen, baselen = base->len;
|
int pathlen, baselen = base->len;
|
||||||
int never_interesting = -1;
|
int never_interesting = -1;
|
||||||
|
|
||||||
if (!ps || !ps->nr)
|
if (!ps->nr) {
|
||||||
|
if (!ps->recursive || ps->max_depth == -1)
|
||||||
return 2;
|
return 2;
|
||||||
|
return !!within_depth(base->buf, baselen,
|
||||||
|
!!S_ISDIR(entry->mode),
|
||||||
|
ps->max_depth);
|
||||||
|
}
|
||||||
|
|
||||||
pathlen = tree_entry_len(entry->path, entry->sha1);
|
pathlen = tree_entry_len(entry->path, entry->sha1);
|
||||||
|
|
||||||
@ -573,7 +579,14 @@ int tree_entry_interesting(const struct name_entry *entry,
|
|||||||
/* If it doesn't match, move along... */
|
/* If it doesn't match, move along... */
|
||||||
if (!match_dir_prefix(base->buf, baselen, match, matchlen))
|
if (!match_dir_prefix(base->buf, baselen, match, matchlen))
|
||||||
continue;
|
continue;
|
||||||
|
|
||||||
|
if (!ps->recursive || ps->max_depth == -1)
|
||||||
return 2;
|
return 2;
|
||||||
|
|
||||||
|
return !!within_depth(base->buf + matchlen + 1,
|
||||||
|
baselen - matchlen - 1,
|
||||||
|
!!S_ISDIR(entry->mode),
|
||||||
|
ps->max_depth);
|
||||||
}
|
}
|
||||||
|
|
||||||
/* Does the base match? */
|
/* Does the base match? */
|
||||||
|
Loading…
x
Reference in New Issue
Block a user