undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't allow git-describe failures to go unnoticed in t6120

Browse Source 
If git-describe fails we never execute the test_expect_success,
so we never actually test for failure.  This is horribly wrong.
We need to always run the test case, but the test case is only
supposed to succeed if the prior git-describe returned 0.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Shawn O. Pearce 2008-03-03 20:09:31 -05:00 committed by Junio C Hamano
parent 3167d72565
commit be7bae0d48
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
t/t6120-describe.sh
View File

@ -15,8 +15,10 @@ test_description='test describe
check_describe () { check_describe () {
expect="$1" expect="$1"
shift shift
R=$(git describe "$@") && R=$(git describe "$@")
S=$?
test_expect_success "describe $*" ' test_expect_success "describe $*" '
test $S = 0 &&
case "$R" in case "$R" in
$expect) echo happy ;; $expect) echo happy ;;
*) echo "Oops - $R is not $expect"; *) echo "Oops - $R is not $expect";