undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

p5326: generate pack bitmaps before writing the MIDX bitmap

Browse Source 
To help test the performance of permuting the contents of the hash-cache
when generating a MIDX bitmap, we need a bitmap which has its hash-cache
populated.

And since multi-pack bitmaps don't add *new* values to the hash-cache,
we have to rely on a single-pack bitmap to generate those values for us.

Therefore, generate a pack bitmap before the MIDX one in order to ensure
that the MIDX bitmap has entries in its hash-cache. Since we don't want
to time generating the pack bitmap, move that to a non-perf test run
before we try to generate the MIDX bitmap.

Likewise, get rid of the pack bitmap afterwords, to make certain that we
are not accidentally using it in the performance tests run later on.

Signed-off-by: Taylor Blau <me@ttaylorr.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Taylor Blau 2021-09-17 17:21:27 -04:00 committed by Junio C Hamano
parent 97b89c8150
commit bf4a60874a
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
t/perf/p5326-multi-pack-bitmaps.sh
View File

@ -12,11 +12,18 @@ test_expect_success 'create tags' '
git tag --message="tag pointing to HEAD" perf-tag HEAD git tag --message="tag pointing to HEAD" perf-tag HEAD
' '
test_expect_success 'start with bitmapped pack' '
git repack -adb
'
test_perf 'setup multi-pack index' ' test_perf 'setup multi-pack index' '
git repack -ad &&
git multi-pack-index write --bitmap git multi-pack-index write --bitmap
' '
test_expect_success 'drop pack bitmap' '
rm -f .git/objects/pack/pack-*.bitmap
'
test_full_bitmap test_full_bitmap
test_expect_success 'create partial bitmap state' ' test_expect_success 'create partial bitmap state' '