undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

name-rev: drop unused parameters from is_better_name()

Browse Source 
When this function was extracted in 0041bf6544 (name-rev: refactor logic
to see if a new candidate is a better name, 2017-03-29), it ended up
getting more arguments than it needs.

It's possible we may later use these values to evaluate the name, but
since it's a static function with a single caller, it will be easy to
add them back then.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Jeff King 2019-05-09 17:30:56 -04:00 committed by Junio C Hamano
parent be27fb7b28
commit c016579895
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
builtin/name-rev.c
View File

@ -40,9 +40,7 @@ static void set_commit_rev_name(struct commit *commit, struct rev_name *name)
} }
static int is_better_name(struct rev_name *name, static int is_better_name(struct rev_name *name,
const char *tip_name,
timestamp_t taggerdate, timestamp_t taggerdate,
int generation,
int distance, int distance,
int from_tag) int from_tag)
{ {
@ -103,8 +101,7 @@ static void name_rev(struct commit *commit,
name = xmalloc(sizeof(rev_name)); name = xmalloc(sizeof(rev_name));
set_commit_rev_name(commit, name); set_commit_rev_name(commit, name);
goto copy_data; goto copy_data;
} else if (is_better_name(name, tip_name, taggerdate, } else if (is_better_name(name, taggerdate, distance, from_tag)) {
generation, distance, from_tag)) {
copy_data: copy_data:
name->tip_name = tip_name; name->tip_name = tip_name;
name->taggerdate = taggerdate; name->taggerdate = taggerdate;