undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

copy_gecos: fix not adding nlen to len when processing "&"

Browse Source 
nlen has to be added to len when inserting (capitalized) pw_name as
substitution for "&" in pw_gecos. Otherwise, pw_gecos will be truncated
and data might be written beyond name+sz.

Signed-off-by: Rafael Gieschke <rafael@gieschke.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Rafael Gieschke 2011-05-16 22:08:21 +02:00 committed by Junio C Hamano
parent 547e8b9205
commit c0336ff27a
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
ident.c
View File

@ -34,6 +34,7 @@ static void copy_gecos(const struct passwd *w, char *name, size_t sz)
*dst++ = toupper(*w->pw_name); *dst++ = toupper(*w->pw_name);
memcpy(dst, w->pw_name + 1, nlen - 1); memcpy(dst, w->pw_name + 1, nlen - 1);
dst += nlen - 1; dst += nlen - 1;
len += nlen;
} }
} }
if (len < sz) if (len < sz)