undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

send-pack: remove remote reference limit

Browse Source 
When build a pack for a push we query the remote copy for existant
heads.  These are used to prune unnecessary objects from the pack.
As we receive the remote references in get_remote_heads() we validate
the reference names via check_ref() which includes a length check;
rejecting those >45 characters in size.

This is a miss converted change, it was originally designed to reject
messages which were less than 45 characters in length (a 40 character
sha1 and refs/) to prevent comparing unitialised memory.  check_ref()
now gets the raw length so check for at least 5 characters.

Signed-off-by: Andy Whitcroft <apw@shadowen.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
This commit is contained in:
Andy Whitcroft 2006-09-05 20:00:17 +01:00 committed by Junio C Hamano
parent 825b045f52
commit c41e20b30b
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
connect.c
View File

@ -17,7 +17,7 @@ static int check_ref(const char *name, int len, unsigned int flags)
if (!flags)
return 1;
if (len > 45 || memcmp(name, "refs/", 5))
if (len < 5 || memcmp(name, "refs/", 5))
return 0;
/* Skip the "refs/" part */