undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

t0003: do not chdir the whole test process

Browse Source 
Moving to some other directory and letting the remainder of the test
pieces to expect that they start there is a bad practice.  The test
that contains chdir itself may fail (or by mistake skipped via the
GIT_SKIP_TESTS mechanism) in which case the remainder may operate on
files in unexpected places.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Junio C Hamano 2014-02-06 10:16:27 -08:00
parent 15999998fb
commit c4a7bce1b5
1 changed files with 30 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

52
t/t0003-attributes.sh
View File

@ -197,39 +197,47 @@ test_expect_success 'root subdir attribute test' '
' '
test_expect_success 'setup bare' ' test_expect_success 'setup bare' '
git clone --bare . bare.git && git clone --bare . bare.git
cd bare.git
' '
test_expect_success 'bare repository: check that .gitattribute is ignored' ' test_expect_success 'bare repository: check that .gitattribute is ignored' '
( (
echo "f test=f" cd bare.git &&
echo "a/i test=a/i" (
) >.gitattributes && echo "f test=f"
attr_check f unspecified && echo "a/i test=a/i"
attr_check a/f unspecified && ) >.gitattributes &&
attr_check a/c/f unspecified && attr_check f unspecified &&
attr_check a/i unspecified && attr_check a/f unspecified &&
attr_check subdir/a/i unspecified attr_check a/c/f unspecified &&
attr_check a/i unspecified &&
attr_check subdir/a/i unspecified
)
' '
test_expect_success 'bare repository: check that --cached honors index' ' test_expect_success 'bare repository: check that --cached honors index' '
GIT_INDEX_FILE=../.git/index \ (
git check-attr --cached --stdin --all <../stdin-all | cd bare.git &&
sort >actual && GIT_INDEX_FILE=../.git/index \
test_cmp ../specified-all actual git check-attr --cached --stdin --all <../stdin-all |
sort >actual &&
test_cmp ../specified-all actual
)
' '
test_expect_success 'bare repository: test info/attributes' ' test_expect_success 'bare repository: test info/attributes' '
( (
echo "f test=f" cd bare.git &&
echo "a/i test=a/i" (
) >info/attributes && echo "f test=f"
attr_check f f && echo "a/i test=a/i"
attr_check a/f f && ) >info/attributes &&
attr_check a/c/f f && attr_check f f &&
attr_check a/i a/i && attr_check a/f f &&
attr_check subdir/a/i unspecified attr_check a/c/f f &&
attr_check a/i a/i &&
attr_check subdir/a/i unspecified
)
' '
test_done test_done