undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sparse: Fix some "symbol not declared" warnings

Browse Source 
In particular, sparse issues the "symbol 'a_symbol' was not declared.
Should it be static?" warnings for the following symbols:

    attr.c:468:12: 'git_etc_gitattributes'
    attr.c:476:5:  'git_attr_system'
    vcs-svn/svndump.c:282:6: 'svndump_read'
    vcs-svn/svndump.c:417:5: 'svndump_init'
    vcs-svn/svndump.c:432:6: 'svndump_deinit'
    vcs-svn/svndump.c:445:6: 'svndump_reset'

The symbols in attr.c only require file scope, so we add the static
modifier to their declaration.

The symbols in vcs-svn/svndump.c are external symbols, and they
already have extern declarations in the "svndump.h" header file,
so we simply include the header in svndump.c.

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Ramsay Jones 2011-04-07 19:49:33 +01:00 committed by Junio C Hamano
parent 0bcd9ae85d
commit c51477229e
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
attr.c
View File

@ -465,7 +465,7 @@ static void drop_attr_stack(void)
} }
} }
const char *git_etc_gitattributes(void) static const char *git_etc_gitattributes(void)
{ {
static const char *system_wide; static const char *system_wide;
if (!system_wide) if (!system_wide)
@ -473,7 +473,7 @@ const char *git_etc_gitattributes(void)
return system_wide; return system_wide;
} }
int git_attr_system(void) static int git_attr_system(void)
{ {
return !git_env_bool("GIT_ATTR_NOSYSTEM", 0); return !git_env_bool("GIT_ATTR_NOSYSTEM", 0);
} }

1
vcs-svn/svndump.c
View File

@ -13,6 +13,7 @@
#include "line_buffer.h" #include "line_buffer.h"
#include "string_pool.h" #include "string_pool.h"
#include "strbuf.h" #include "strbuf.h"
#include "svndump.h"
/* /*
* Compare start of string to literal of equal length; * Compare start of string to literal of equal length;