Merge branch 'jk/tempfile-ferror-fclose-confusion'

Code clean-up. * jk/tempfile-ferror-fclose-confusion: tempfile: avoid "ferror | fclose" trick
2017-02-16 14:45:15 -08:00 · 2017-02-16 14:45:15 -08:00 · c5b22b819d
commit c5b22b819d
parent 62fef5c564 0838cbc22f
1 changed files with 2 additions and 6 deletions
--- a/tempfile.c
+++ b/tempfile.c
@ -247,12 +247,8 @@ int close_tempfile(struct tempfile *tempfile)
 	tempfile->fd = -1;
 	if (fp) {
 		tempfile->fp = NULL;
-
-		/*
-		 * Note: no short-circuiting here; we want to fclose()
-		 * in any case!
-		 */
-		err = ferror(fp) | fclose(fp);
+		err = ferror(fp);
+		err |= fclose(fp);
 	} else {
 		err = close(fd);
 	}