undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

merge-recursive: ensure we write updates for directory-renamed file

Browse Source 
When a file is present in HEAD before the merge and the other side of the
merge does not modify that file, we try to avoid re-writing the file and
making it stat-dirty.  However, when a file is present in HEAD before the
merge and was in a directory that was renamed by the other side of the
merge, we have to move the file to a new location and re-write it.
Update the code that checks whether we can skip the update to also work in
the presence of directory renames.

Reviewed-by: Stefan Beller <sbeller@google.com>
Signed-off-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Elijah Newren 2018-02-14 10:52:06 -08:00 committed by Junio C Hamano
parent febb3a8609
commit c5b761fb27
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
merge-recursive.c
View File

@ -2763,7 +2763,6 @@ static int merge_content(struct merge_options *o,
if (mfi.clean && !df_conflict_remains && if (mfi.clean && !df_conflict_remains &&
oid_eq(&mfi.oid, a_oid) && mfi.mode == a_mode) { oid_eq(&mfi.oid, a_oid) && mfi.mode == a_mode) {
int path_renamed_outside_HEAD;
output(o, 3, _("Skipped %s (merged same as existing)"), path); output(o, 3, _("Skipped %s (merged same as existing)"), path);
/* /*
* The content merge resulted in the same file contents we * The content merge resulted in the same file contents we
@ -2771,8 +2770,7 @@ static int merge_content(struct merge_options *o,
* are recorded at the correct path (which may not be true * are recorded at the correct path (which may not be true
* if the merge involves a rename). * if the merge involves a rename).
*/ */
path_renamed_outside_HEAD = !path2 || !strcmp(path, path2); if (was_tracked(path)) {
if (!path_renamed_outside_HEAD) {
add_cacheinfo(o, mfi.mode, &mfi.oid, path, add_cacheinfo(o, mfi.mode, &mfi.oid, path,
0, (!o->call_depth), 0); 0, (!o->call_depth), 0);
return mfi.clean; return mfi.clean;

2
t/t6043-merge-rename-directories.sh
View File

@ -3884,7 +3884,7 @@ test_expect_success '12b-setup: Moving one directory hierarchy into another' '
) )
' '
test_expect_failure '12b-check: Moving one directory hierarchy into another' ' test_expect_success '12b-check: Moving one directory hierarchy into another' '
( (
cd 12b && cd 12b &&