undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge branch 'jk/stream-pack-non-delta-clarification'

Browse Source 
Additional comment on a tricky piece of code to help developers.

* jk/stream-pack-non-delta-clarification:
  read_istream_pack_non_delta(): document input handling
This commit is contained in:
Junio C Hamano 2018-11-13 22:37:18 +09:00
commit c657aa0525
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
streaming.c
View File

@ -408,6 +408,15 @@ static read_method_decl(pack_non_delta)
st->z_state = z_done; st->z_state = z_done;
break; break;
} }
/*
* Unlike the loose object case, we do not have to worry here
* about running out of input bytes and spinning infinitely. If
* we get Z_BUF_ERROR due to too few input bytes, then we'll
* replenish them in the next use_pack() call when we loop. If
* we truly hit the end of the pack (i.e., because it's corrupt
* or truncated), then use_pack() catches that and will die().
*/
if (status != Z_OK && status != Z_BUF_ERROR) { if (status != Z_OK && status != Z_BUF_ERROR) {
git_inflate_end(&st->z); git_inflate_end(&st->z);
st->z_state = z_error; st->z_state = z_error;