undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

git-bisect.sh: avoid "test <cond> -a/-o <cond>"

Browse Source 
The construct is error-prone; "test" being built-in in most modern
shells, the reason to avoid "test <cond> && test <cond>" spawning
one extra process by using a single "test <cond> -a <cond>" no
longer exists.

Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Elia Pinto 2014-06-06 07:55:50 -07:00 committed by Junio C Hamano
parent 6f34b79de1
commit c82af12a1b
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
git-bisect.sh
View File

@ -408,7 +408,7 @@ bisect_replay () {
bisect_reset bisect_reset
while read git bisect command rev while read git bisect command rev
do do
test "$git $bisect" = "git bisect" -o "$git" = "git-bisect" || continue test "$git $bisect" = "git bisect" || test "$git" = "git-bisect" || continue
if test "$git" = "git-bisect" if test "$git" = "git-bisect"
then then
rev="$command" rev="$command"