Merge branch 'fc/trivial'

* fc/trivial:
  pull: use $curr_branch_short more
  add: trivial style cleanup
  reset: trivial style cleanup
  branch: trivial style fix
  reset: trivial refactoring
This commit is contained in:
Junio C Hamano 2013-09-17 11:42:34 -07:00
commit c8ccfc9cdf
4 changed files with 12 additions and 16 deletions

View File

@ -330,11 +330,14 @@ int cmd_reset(int argc, const char **argv, const char *prefix)
die_if_unmerged_cache(reset_type); die_if_unmerged_cache(reset_type);
if (reset_type != SOFT) { if (reset_type != SOFT) {
struct lock_file *lock = xcalloc(1, sizeof(struct lock_file)); struct lock_file *lock = xcalloc(1, sizeof(*lock));
int newfd = hold_locked_index(lock, 1); int newfd = hold_locked_index(lock, 1);
if (reset_type == MIXED) { if (reset_type == MIXED) {
int flags = quiet ? REFRESH_QUIET : REFRESH_IN_PORCELAIN;
if (read_from_tree(&pathspec, sha1)) if (read_from_tree(&pathspec, sha1))
return 1; return 1;
refresh_index(&the_index, flags, NULL, NULL,
_("Unstaged changes after reset:"));
} else { } else {
int err = reset_index(sha1, reset_type, quiet); int err = reset_index(sha1, reset_type, quiet);
if (reset_type == KEEP && !err) if (reset_type == KEEP && !err)
@ -343,12 +346,6 @@ int cmd_reset(int argc, const char **argv, const char *prefix)
die(_("Could not reset index file to revision '%s'."), rev); die(_("Could not reset index file to revision '%s'."), rev);
} }
if (reset_type == MIXED) { /* Report what has not been updated. */
int flags = quiet ? REFRESH_QUIET : REFRESH_IN_PORCELAIN;
refresh_index(&the_index, flags, NULL, NULL,
_("Unstaged changes after reset:"));
}
if (write_cache(newfd, active_cache, active_nr) || if (write_cache(newfd, active_cache, active_nr) ||
commit_locked_index(lock)) commit_locked_index(lock))
die(_("Could not write new index file.")); die(_("Could not write new index file."));

View File

@ -187,9 +187,8 @@ error_on_no_merge_candidates () {
op_prep=with op_prep=with
fi fi
curr_branch=${curr_branch#refs/heads/} upstream=$(git config "branch.$curr_branch_short.merge")
upstream=$(git config "branch.$curr_branch.merge") remote=$(git config "branch.$curr_branch_short.remote")
remote=$(git config "branch.$curr_branch.remote")
if [ $# -gt 1 ]; then if [ $# -gt 1 ]; then
if [ "$rebase" = true ]; then if [ "$rebase" = true ]; then