undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

relative_url(): fix incorrect condition

Browse Source 
In 63e95beb08 (submodule: port resolve_relative_url from shell to C,
2016-04-15), we added a loop over `url` where we are looking for `../`
or `./` components.

The loop condition we used is the pointer `url` itself, which is clearly
not what we wanted.

Pointed out by Coverity.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Johannes Schindelin 2022-06-15 23:35:44 +00:00 committed by Junio C Hamano
parent 41f1a8e6a4
commit c918f5c1ab
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
remote.c
View File

@ -2846,7 +2846,7 @@ char *relative_url(const char *remote_url, const char *url,
* When the url starts with '../', remove that and the * When the url starts with '../', remove that and the
* last directory in remoteurl. * last directory in remoteurl.
*/ */
while (url) { while (*url) {
if (starts_with_dot_dot_slash_native(url)) { if (starts_with_dot_dot_slash_native(url)) {
url += 3; url += 3;
colonsep |= chop_last_dir(&remoteurl, is_relative); colonsep |= chop_last_dir(&remoteurl, is_relative);