mailmap: replace strcpy with xstrdup
We want to make a copy of a string without any leading whitespace. To do so, we allocate a buffer large enough to hold the original, skip past the whitespace, then copy that. It's much simpler to just allocate after we've skipped, in which case we can just copy the remainder of the string, leaving no question of whether "len" is large enough. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
parent
acd47eec99
commit
c978610dc8
@ -162,11 +162,10 @@ static void read_mailmap_line(struct string_list *map, char *buffer,
|
|||||||
char *cp;
|
char *cp;
|
||||||
|
|
||||||
free(*repo_abbrev);
|
free(*repo_abbrev);
|
||||||
*repo_abbrev = xmalloc(len);
|
|
||||||
|
|
||||||
for (cp = buffer + abblen; isspace(*cp); cp++)
|
for (cp = buffer + abblen; isspace(*cp); cp++)
|
||||||
; /* nothing */
|
; /* nothing */
|
||||||
strcpy(*repo_abbrev, cp);
|
*repo_abbrev = xstrdup(cp);
|
||||||
}
|
}
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
Loading…
Reference in New Issue
Block a user