undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

t9360-mw-to-git-clone.sh: use the $( ... ) construct for command substitution

Browse Source 
The Git CodingGuidelines prefer the $(...) construct for command
substitution instead of using the backquotes `...`.

The backquoted form is the traditional method for command
substitution, and is supported by POSIX.  However, all but the
simplest uses become complicated quickly.  In particular, embedded
command substitutions and/or the use of double quotes require
careful escaping with the backslash character.

The patch was generated by:

for _f in $(find . -name "*.sh")
do
   sed -i 's@`\(.*\)`@$(\1)@g' ${_f}
done

and then carefully proof-read.

Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Elia Pinto 2014-04-16 10:29:57 -07:00 committed by Junio C Hamano
parent b352891021
commit c9b92706af
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
contrib/mw-to-git/t/t9360-mw-to-git-clone.sh
View File

@ -191,10 +191,10 @@ test_expect_success 'Git clone works with the shallow option' '
test_path_is_file mw_dir_11/Main_Page.mw &&
(
cd mw_dir_11 &&
test `git log --oneline Nyan.mw | wc -l` -eq 1 &&
test `git log --oneline Foo.mw | wc -l` -eq 1 &&
test `git log --oneline Bar.mw | wc -l` -eq 1 &&
test `git log --oneline Main_Page.mw | wc -l ` -eq 1
test $(git log --oneline Nyan.mw | wc -l) -eq 1 &&
test $(git log --oneline Foo.mw | wc -l) -eq 1 &&
test $(git log --oneline Bar.mw | wc -l) -eq 1 &&
test $(git log --oneline Main_Page.mw | wc -l ) -eq 1
) &&
wiki_check_content mw_dir_11/Nyan.mw Nyan &&
wiki_check_content mw_dir_11/Foo.mw Foo &&
@ -218,9 +218,9 @@ test_expect_success 'Git clone works with the shallow option with a delete page'
test_path_is_file mw_dir_12/Main_Page.mw &&
(
cd mw_dir_12 &&
test `git log --oneline Nyan.mw | wc -l` -eq 1 &&
test `git log --oneline Bar.mw | wc -l` -eq 1 &&
test `git log --oneline Main_Page.mw | wc -l ` -eq 1
test $(git log --oneline Nyan.mw | wc -l) -eq 1 &&
test $(git log --oneline Bar.mw | wc -l) -eq 1 &&
test $(git log --oneline Main_Page.mw | wc -l ) -eq 1
) &&
wiki_check_content mw_dir_12/Nyan.mw Nyan &&
wiki_check_content mw_dir_12/Bar.mw Bar &&